feat(ADMIN-262): 행사 페이지 기능 추가 및 로그인 권한 설정 - #2
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough관리자 인증/가드 도입과 OAuth 로그인 전환, 활동(Activity) 관리용 API 클라이언트 추가, 이벤트 테이블의 생성/수정/삭제 통합, QR 스캔 흐름의 내부 처리화, 헤더 내 네비게이션 추가, CSS 유틸 클래스 추가, 루트 렌더 트리에 AuthProvider 적용 및 관련 페이지들의 가드/데이터 연동이 반영되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Admin as Admin(브라우저)
participant EventPage as Event Page
participant EventTable as EventTable
participant ActivityAPI as Activity API(클라이언트)
Note over EventPage: 마운트 후 인증 완료 시
EventPage->>ActivityAPI: GetActivities()
ActivityAPI-->>EventPage: Activity[]
EventPage->>EventTable: rows, setRows 전달
Admin->>EventTable: 생성/수정/삭제 조작
alt 생성
EventTable->>ActivityAPI: PostMemberActivities(name, pointAmount)
else 수정
EventTable->>ActivityAPI: updateActivity(id, name, point)
else 삭제
EventTable->>ActivityAPI: deleteActivity(id)
end
EventTable->>ActivityAPI: GetActivities() (갱신)
ActivityAPI-->>EventTable: Activity[]
EventTable-->>EventPage: setRows로 반영
sequenceDiagram
autonumber
actor Admin as Admin(브라우저)
participant QRScanner as QRScanner
participant LocalStorage as localStorage
participant ActivityAPI as Activity API(클라이언트)
Admin->>QRScanner: QR 모달 열기
QRScanner->>LocalStorage: currentActivityId 읽기
alt activityId 없음
QRScanner-->>Admin: 경고 표시 후 닫기
else activityId 있음
Admin->>QRScanner: QR 스캔 결과(uuid)
QRScanner->>ActivityAPI: GetQRCode(uuid)
alt 회원 조회 성공
ActivityAPI-->>QRScanner: MemberInfo
QRScanner->>ActivityAPI: PostMemberActivities(activityId, memberId)
ActivityAPI-->>QRScanner: 성공/실패
QRScanner-->>Admin: 결과 알림 및 스로틀링 적용
else 회원 조회 실패
ActivityAPI-->>QRScanner: 오류
QRScanner-->>Admin: 오류 알림 후 스캐너 정리/닫기
end
end
sequenceDiagram
autonumber
participant App as App
participant AuthProvider as AuthProvider
participant MembersAPI as /members API
participant Route as Protected Page
App->>AuthProvider: 마운트
AuthProvider->>MembersAPI: Members()
MembersAPI-->>AuthProvider: {role,name} 또는 오류
AuthProvider-->>Route: isAuthenticated 상태 제공
Route->>Route: useAuthGuard 검사
alt 미인증
Route->>Route: /login으로 이동
else 인증
Route-->>App: 콘텐츠 렌더
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge Base: Disabled due to data retention organization setting 📒 Files selected for processing (17)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit